Copy target min python check into ansiballz template

[sivel]

SUMMARY

Copy target min python check into ansiballz template. Fixes #82068

ISSUE TYPE

• Bugfix Pull Request

ADDITIONAL INFORMATION

porky | FAILED! => {
    "changed": false,
    "msg": "ansible-core requires a minimum of Python version 3.7. Current version: 3.6.12 (default, Sep 17 2020, 10:43:21) [GCC 9.3.0]"
}

[mattclay]

The code changes look fine. However, my original concerns mentioned in #82068 (comment) still apply:

• It's difficult to automate testing for the Python version check, since it requires a Python version that we don't otherwise support.
• If we decide to use newer Python syntax in the AnsiballZ wrapper at some point, then the check will have the same issues the one in basic.py currently has.

[jdicke]

The sys.version attribute typically returns a string with additional information, such as the build date and other details. Using splitlines() on sys.version might not give you the desired version format.

[webknjaz]

Looks like restarting the CI doesn't help clear out those macOS issues. This seems related to #73505. At the moment, I don't understand why this PR is affected but others don't seem to be...

[webknjaz]

I checked this out locally, merged in devel and it keeps failing with --remote macos/14.3 consistently, just like with --remote macos/13.2. And switching to clean devel doesn't have this issue.

I don't know what it is exactly, but clearly the PR is somehow causing the following integration tests to fail:

• become
• copy
• keyword_inheritance
• ansible-galaxy-collection-scm

It looks like something removes the underlying working directory while modules are being executed. And then, os.getcwd() gets called and that's where that OSError is coming from. For some reason, this seems to be happening in conjunction with become: yes.

In case of copy, there's actually a visible removal in the log:

<testhost> EXEC /bin/sh -c 'sudo -H -S -n  -u nobody /bin/sh -c '"'"'echo BECOME-SUCCESS-qcbxuucefxjxyispipwalmtonykdixaa ; /usr/local/bin/python3.11'"'"' && sleep 0'
<testhost> EXEC /bin/sh -c 'rm -f -r /var/tmp/ansible-tmp-1708120536.920125-7434-145564630886208/ > /dev/null 2>&1 && sleep 0'
fatal: [testhost]: FAILED! => {
    "msg": "Failed to get information on remote file (/tmp/worldwritable/file.txt): shell-init: error retrieving current directory: getcwd: cannot access parent directories: Permission denied\njob-working-directory: error retrieving current directory: getcwd: cannot access parent directories: Permission denied\nTraceback (most recent call last):\n  File \"<stdin>\", line 6, in <module>\n  File \"<frozen importlib._bootstrap>\", line 1178, in _find_and_load\n  File \"<frozen importlib._bootstrap>\", line 1140, in _find_and_load_unlocked\n  File \"<frozen importlib._bootstrap>\", line 1080, in _find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1504, in find_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1473, in _get_spec\n  File \"<frozen importlib._bootstrap_external>\", line 1431, in _path_importer_cache\nPermissionError: [Errno 13] Permission denied\n"
}

(https://dev.azure.com/ansible/ansible/_build/results?buildId=104232&view=logs&j=a5bc2140-af2a-524a-0c25-b9b66206fded&t=b4892af7-c3bb-5bba-9fe6-5272a87e2a89&l=19477)

I unescaped the traceback for readability:

Failed to get information on remote file (/tmp/worldwritable/file.txt): shell-init: error retrieving current directory: getcwd: cannot access parent directories: Permission denied
job-working-directory: error retrieving current directory: getcwd: cannot access parent directories: Permission denied
Traceback (most recent call last):
  File "<stdin>", line 6, in <module>
  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1080, in _find_spec
  File "<frozen importlib._bootstrap_external>", line 1504, in find_spec
  File "<frozen importlib._bootstrap_external>", line 1473, in _get_spec
  File "<frozen importlib._bootstrap_external>", line 1431, in _path_importer_cache
PermissionError: [Errno 13] Permission denied

[mattclay]

Move this down below the existing check (if sys.version_info < (3,):) -- that will fix the macOS failures.

[mattclay]

Remove this import, it won't be needed once the insertion point is moved.

[mattclay]

Move this import just above the print statement below, so it's not imported here unless it's needed.

[webknjaz]

I just verified that import json is definitely what's calling os.getcwd() somewhere during import time. Commenting the lines below doesn't make the error go away, dropping this import too does.

[webknjaz]

Underlying problem reproducer:

root@administrators-Mac:~/ansible$ mkdir /tmp/oserror-repro
root@administrators-Mac:~/ansible$ cd /tmp/oserror-repro
root@administrators-Mac:/tmp/oserror-repro$ chmod 777 .
root@administrator python3 -c 'import time; time.sleep(5); from os import getcwd; print(f"{getcwd()= !r}")' &
[1] 570
root@administrators-Mac:/tmp/oserror-repro$ chmod 000 /tmp/oserror-repro
root@administrators-Mac:/tmp/oserror-repro$ Traceback (most recent call last):
  File "<string>", line 1, in <module>
PermissionError: [Errno 13] Permission denied

[1]+  Exit 1                  sudo -u administrator python3 -c 'import time; time.sleep(5); from os import getcwd; print(f"{getcwd()= !r}")'

root@administrators-Mac:/tmp/oserror-repro$ chmod 777 /tmp/oserror-repro
root@administrators-Mac:/tmp/oserror-repro$ sudo -u administrator python3 -c 'import time; time.sleep(5); import json' &
[1] 633
root@administrators-Mac:/tmp/oserror-repro$ chmod 000 /tmp/oserror-repro
root@administrators-Mac:/tmp/oserror-repro$ Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1080, in _find_spec
  File "<frozen importlib._bootstrap_external>", line 1504, in find_spec
  File "<frozen importlib._bootstrap_external>", line 1473, in _get_spec
  File "<frozen importlib._bootstrap_external>", line 1431, in _path_importer_cache
PermissionError: [Errno 13] Permission denied

[1]+  Exit 1                  sudo -u administrator python3 -c 'import time; time.sleep(5); import json'

[webknjaz]

This is happening with other modules, some of which are imported by json. Namely, _json, re, _re and sysconfig. But not codecs.

I found that the exception in the traceback is coming from the call to os.getcwd() @ https://github.com/python/cpython/blob/v3.11.2/Lib/importlib/_bootstrap_external.py#L1431 which indicates a bug in CPython stdlib. There is only one place in that module that guards against a PermissionError that was added over a decade ago (python/cpython@a9976b3).

Not sure which imports hit that code path, though. Perhaps the ones loading C-extensions... In case of sysconfig, though, it's happening right in the Python module during import.