Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

any_errors_fatal: do not fail unreachable hosts #82852

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

any_errors_fatal: do not fail unreachable hosts #82852

wants to merge 1 commit into from
+29 −1

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Mar 19, 2024 •
edited

SUMMARY

Fixes #82834

ci_complete

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION

@mkrizek mkrizek marked this pull request as draft March 19, 2024 16:35
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. labels Mar 19, 2024
@mkrizek mkrizek marked this pull request as ready for review March 20, 2024 14:07
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Mar 21, 2024
@nitzmahone
Copy link
Member

We might need to consider either making any_errors_fatal accept a non-boolean or use another keyword, because this is almost certainly a breaking change as-is. This functionality is sorely needed, but we need to work through the backward-compat implications.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. has_issue stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

any_errors_fatal doesn't work when a remote host is unreachable in the given batch
3 participants
@mkrizek @nitzmahone @ansibot