Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection: update test coverage for SSH connection plugin #82916

Merged
merged 2 commits into from Apr 2, 2024
Merged

connection: update test coverage for SSH connection plugin #82916

merged 2 commits into from Apr 2, 2024

Conversation

Akasurde
Copy link
Member

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Test Pull Request

@Akasurde
connection: update test coverage for SSH connection plugin
451597b 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde requested a review from bcoca March 27, 2024 01:04
@ansibot ansibot added test This PR relates to tests. needs_triage Needs a first human triage before being processed. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 27, 2024
@ansibot
Copy link
Contributor

ansibot commented Mar 27, 2024

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/plugins/connection/test_ssh.py:331:1: E302: expected 2 blank lines, found 1

click here for bot help

@Akasurde
sanity fixes
c111b33 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Mar 27, 2024
@bcoca bcoca merged commit 21a987b into ansible:devel Apr 2, 2024
67 checks passed
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 2, 2024
@Akasurde Akasurde deleted the ssh_connection_test branch April 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Akasurde @ansibot @bcoca