Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

centralize and complete the internal static vars (#82872) #82926

Closed
wants to merge 2 commits into from
Closed

centralize and complete the internal static vars (#82872) #82926

wants to merge 2 commits into from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 28, 2024

ISSUE TYPE
  • Bugfix Pull Request

bcoca and others added 2 commits March 28, 2024 15:11
@bcoca
centralize and complete the internal static vars (ansible#82872)
bbc50da 
* centralize and complete the internal static vars

These vars are internal and should not be overridden nor templated
from inventory nor hostvars.

(cherry picked from commit 8704b9f)
@bcoca
correct merge
d839c4a
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. backport This PR does not target the devel branch. labels Mar 28, 2024
@bcoca bcoca changed the title Internal static vars b2 centralize and complete the internal static vars (#82872) Mar 28, 2024
@webknjaz
Copy link
Member

webknjaz commented Apr 2, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 2, 2024
@sivel
Copy link
Member

sivel commented Apr 10, 2024

Classifying this backport as general, and not critical.

@sivel sivel closed this Apr 10, 2024
@bcoca bcoca deleted the internal_static_vars_b2 branch April 10, 2024 19:33
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport This PR does not target the devel branch. bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoca @webknjaz @sivel @ansibot