[2.15] fix handling allow_duplicates with the role cache (#82691) #82928
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
allow_duplicates is not part of the role uniqueness, so the value on the cached role may not match the current role. * remove the allow_duplicates check from Role.has_run() which operates on the deduplicated role * check the current role's allow_duplicates value in the strategy (cherry picked from commit b3d8cdd) Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
s-hertel
force-pushed
the
backport/2.15/82691
branch
from
4154adb
to
fa8a1f4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
needs_revision
sivel
removed
the
needs_triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport for #82691
allow_duplicates is not part of the role uniqueness, so the value on the cached role may not match the current role.
Co-authored-by: Martin Krizek martin.krizek@gmail.com
(cherry picked from commit b3d8cdd)
ISSUE TYPE
ADDITIONAL INFORMATION