Skip to content

Prevent extra vars from bleeding into hostvars#82995

Open
bcoca wants to merge 8 commits intoansible:develfrom
bcoca:fix_extra_bleed_hostvars
Open

Prevent extra vars from bleeding into hostvars#82995
bcoca wants to merge 8 commits intoansible:develfrom
bcoca:fix_extra_bleed_hostvars

Conversation

@bcoca
Copy link
Member

@bcoca bcoca commented Apr 5, 2024

except when they override an existing hostvar

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 5, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Apr 9, 2024
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Apr 9, 2024
@ansible ansible deleted a comment from ansibot Apr 9, 2024
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Apr 9, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 23, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 21, 2024
@bcoca bcoca force-pushed the fix_extra_bleed_hostvars branch from cf400e2 to 12423ea Compare May 29, 2024 22:26
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 29, 2024
@bcoca bcoca marked this pull request as ready for review May 30, 2024 19:00
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 30, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label May 31, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 14, 2024
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jul 5, 2024
bcoca added 6 commits February 4, 2025 10:59
@bcoca
Prevent extra vars from bleeding into hostvars
0f46a63 
 except when they override an existing hostvar
@bcoca
tiemize
3a9bc35
@bcoca
minor fixes
eb5633c
@bcoca
allow hostvars use of extra vars for templating
81a07de 
now that we don't shove all of them in, we still
pass them to templar for use in templating
@bcoca
tested
22aec85
@bcoca
add config toggle
bd21d5e
@bcoca bcoca force-pushed the fix_extra_bleed_hostvars branch from cf5ad39 to bd21d5e Compare February 4, 2025 16:02
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Feb 4, 2025
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 4, 2025
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Feb 4, 2025
webknjaz
webknjaz reviewed Feb 4, 2025
View reviewed changes
@ansible ansible deleted a comment from ansibot Feb 4, 2025
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 4, 2025
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Feb 4, 2025
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 18, 2025
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 15, 2025
@bcoca bcoca mentioned this pull request Feb 9, 2026
Open
@ansibot ansibot added the stale_pr This PR has not been pushed to for more than one year. label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz left review comments

Assignees

No one assigned

Labels

bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_pr This PR has not been pushed to for more than one year.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bcoca @webknjaz @ansibot @s-hertel