Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version ceiling for pypsrp #83122

Merged
merged 3 commits into from Apr 30, 2024
Merged

Add version ceiling for pypsrp #83122

merged 3 commits into from Apr 30, 2024

Conversation

jborean93
Copy link
Contributor

SUMMARY

Add a version ceiling for the pypsrp requirements. This ensures that the future v1.0.0 release won't impact existing users who install the library using the version range specified.

ISSUE TYPE
  • Docs Pull Request

Add a version ceiling for the pypsrp requirements. This ensures that the
future v1.0.0 release won't impact existing users who install the
library using the version range specified.
@ansibot ansibot added needs_triage Needs a first human triage before being processed. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 23, 2024
@ansibot
Copy link
Contributor

ansibot commented Apr 23, 2024

The test ansible-test sanity --test test-constraints [explain] failed with 1 error:

test/lib/ansible_test/_data/requirements/windows-integration.txt:4:1: put the constraint (pypsrp>=0.4.0, <1.0.0) in `test/lib/ansible_test/_data/requirements/constraints.txt`

click here for bot help

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 23, 2024
Copy link
Member

@mattclay mattclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could use a changelog entry.

@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Apr 29, 2024
@jborean93
Copy link
Contributor Author

Thanks, have added the fragment.

@jborean93 jborean93 merged commit 2ed6c30 into ansible:devel Apr 30, 2024
66 checks passed
@jborean93 jborean93 deleted the pypsrp-req branch April 30, 2024 00:10
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 30, 2024
* Add version ceiling for pypsrp

Add a version ceiling for the pypsrp requirements. This ensures that the
future v1.0.0 release won't impact existing users who install the
library using the version range specified.

* Use constraints file

* Add changelog for this change

(cherry picked from commit 2ed6c30)
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 30, 2024
* Add version ceiling for pypsrp

Add a version ceiling for the pypsrp requirements. This ensures that the
future v1.0.0 release won't impact existing users who install the
library using the version range specified.

* Use constraints file

* Add changelog for this change

(cherry picked from commit 2ed6c30)
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 30, 2024
* Add version ceiling for pypsrp

Add a version ceiling for the pypsrp requirements. This ensures that the
future v1.0.0 release won't impact existing users who install the
library using the version range specified.

* Use constraints file

* Add changelog for this change

(cherry picked from commit 2ed6c30)
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 30, 2024
* Add version ceiling for pypsrp

Add a version ceiling for the pypsrp requirements. This ensures that the
future v1.0.0 release won't impact existing users who install the
library using the version range specified.

* Use constraints file

* Add changelog for this change

(cherry picked from commit 2ed6c30)
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 30, 2024
* Add version ceiling for pypsrp

Add a version ceiling for the pypsrp requirements. This ensures that the
future v1.0.0 release won't impact existing users who install the
library using the version range specified.

* Use constraints file

* Add changelog for this change

(cherry picked from commit 2ed6c30)
@jborean93
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants