cron: return stdout and rc for cron command #83290
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
feature
Akasurde
reviewed
May 21, 2024
| @@ -325,7 +325,7 @@ def write(self, backup_file=None): | |||
| os.unlink(path) | |||
|
|
|||
| if rc != 0: | |||
| self.module.fail_json(msg=err) | |||
| self.module.fail_json(msg=err, stdout=out, rc=rc) | |||
There was a problem hiding this comment.
Could you please add a changelog and test for this change?
There was a problem hiding this comment.
I would move err to stderr= and update msg= with ''failed to install new cronfile: {path}' or something similar and informative that does not rely on (mostly cryptic) OS errors.
mattclay
removed
the
needs_triage
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds a little more info to cron module output, as referenced in #83223
ISSUE TYPE