Make sure ansible-doc work when stdin is not a tty #9809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used from another non interactive software, see ansible#9695 for details.
(less) 2> /dev/null would fail if stdin is /dev/null. Sinceless --version do not read anything from stdin, it is perfect for seeing if the software exist or not. Also replace the whole os system detection by directly using subprocess ( as we use it elsewhere, we already depend on it ).
abadger
added a commit
that referenced
this pull request
Dec 16, 2014
Make sure ansible-doc work when stdin is not a tty
|
Thanks for the fix! MergedHi! This has been merged in, and will also be included in the next major release. If you or anyone else has any further questions, please let us know by stopping by one of the two mailing lists, as appropriate:
Because this project is very active, we're unlikely to see comments made on closed tickets, but the mailing list is a great way to ask questions, or post if you don't think this particular Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9695