Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use send instead of sendv on the systemd.journal (fixes #9886) #9887

Merged
merged 1 commit into from Jan 20, 2015

Conversation

lmacken
Copy link
Contributor

@lmacken lmacken commented Dec 24, 2014

On systemd-216-13.fc21 with ansible-1.8.2-1.fc21 the simple example from #9886 is triggering journald assertions. For some reason the ansible module arguments being passed into journal.sendv are causing the problem, but passing them into journal.send as keyword arguments seems to work around the issue.

@lmacken
Copy link
Contributor Author

lmacken commented Dec 24, 2014

Using journal.send instead of sendv also has the added benefit of systemd automatically populating the CODE_FILE, CODE_LINE, and CODE_FUNC fields for us.

@lmacken lmacken changed the title Don't send arbitrary fields to the systemd journal (fixes #9886) Use send instead of sendv on the systemd.journal (fixes #9886) Dec 24, 2014
@lmacken
Copy link
Contributor Author

lmacken commented Dec 24, 2014

I also filed a bug against systemd https://bugzilla.redhat.com/1177184

@bcoca bcoca added P3 labels Dec 25, 2014
@ghost
Copy link

ghost commented Jan 18, 2015

ooh that'd be super cool if ansible had this fix to populate those lines!

abadger added a commit that referenced this pull request Jan 20, 2015
Use send instead of sendv on the systemd.journal (fixes #9886)
@abadger abadger merged commit e6b5cc9 into ansible:devel Jan 20, 2015
@abadger
Copy link
Contributor

abadger commented Jan 20, 2015

Looks good. Straightforward switching of which API function we use.

Merged

Hi!

This has been merged in, and will also be included in the next major release.

If you or anyone else has any further questions, please let us know by stopping by one of the two mailing lists, as appropriate:

Because this project is very active, we're unlikely to see comments made on closed tickets, but the mailing list is a great way to ask questions, or post if you don't think this particular
issue is resolved.

Thank you!

@lmacken
Copy link
Contributor Author

lmacken commented Jan 20, 2015

Thanks Toshio! 🍻

@abadger
Copy link
Contributor

abadger commented Jan 20, 2015

Applied change to the v2 tree as well: 2a04663

Thanks lmacken!

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants