This repository has been archived by the owner on May 23, 2024. It is now read-only.
Check before update attribute of basemodel #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blomquisg
reviewed
May 2, 2017
| send("#{method_name}=", value) | ||
| invoke_name = "#{override_raw_attributes[method_name] ? override_raw_attributes[method_name] : method_name}=" | ||
| if respond_to?(invoke_name) | ||
| send(invoke_name, value) |
There was a problem hiding this comment.
Probably need a else or rescue here that logs a debug message saying it couldn't write to a specific attribute name.
There was a problem hiding this comment.
Done. Also added a spec test.
bdunne
suggested changes
May 3, 2017
| @@ -82,10 +82,11 @@ def self.create(*args) | |||
| def update_attributes!(attributes) | |||
| @api.patch(url, attributes.to_json) | |||
| attributes.each do |method_name, value| | |||
| if override_raw_attributes[method_name] | |||
| send("#{override_raw_attributes[method_name]}=", value) | |||
| invoke_name = "#{override_raw_attributes[method_name] ? override_raw_attributes[method_name] : method_name}=" | |||
There was a problem hiding this comment.
override_raw_attributes[method_name] ? override_raw_attributes[method_name] : method_name
can be simplified to:
override_raw_attributes[method_name] || method_name
|
Checked commit jameswnl@5f85374 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
May 3, 2017
jameswnl
changed the title
|
@miq-bot remove_label wip |
blomquisg
approved these changes
May 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix https://bugzilla.redhat.com/show_bug.cgi?id=1445995
When caller passes in attributes that client doesn't know, even though Tower succeed in the call, client is blown up.
@miq-bot add_labels wip, bug