Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

github token and namespace support in PR bot #35

Merged
merged 3 commits into from
Feb 22, 2016

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Feb 22, 2016

I implemented github private token support, useful if you enabled 2fa
(you should...). You can then just pass --ghtoken to the cli.
Find more about gh token here
https://help.github.com/articles/creating-an-access-token-for-command-line-use/

Further I implemented support for "namespaces":

e.g. cloud/cloudstack/: resmo

This means I would also be added as maintainer for any PR in this namespace.

@gregdek
Copy link
Contributor

gregdek commented Feb 22, 2016

THANK GOD

gregdek added a commit that referenced this pull request Feb 22, 2016
github token and namespace support in PR bot
@gregdek gregdek merged commit 694d76f into ansible:master Feb 22, 2016
@resmo resmo deleted the feature/ghtoken-and-namespace branch February 22, 2016 22:10
@gregdek
Copy link
Contributor

gregdek commented Feb 23, 2016

That'll teach me to merge before testing. :)

The issue appears to be that the new handle_url code doesn't appear to be returning properly. So r.links, which expects to be this:

{'last': {'url': 'https://api.github.com/repositories/24474138/pulls?state=open&page=10', 'rel': 'last'}, 'next': {'url': 'https://api.github.com/repositories/24474138/pulls?state=open&page=2', 'rel': 'next'}}

...is instead just {}.

It may also be that the new code doesn't handle user/pass, which is still what we're using.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants