WIP: add support for issues to triage.py #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some refactoring so PullRequest* inherits from Issue*. Add a --dry-run mode for testing and read-only operation. Add a TriageIssue and TriagePullRequest classes, that implement some of the issue type specific triage workflow. Add a Issue and PullRequest class for the Triage classes to use. Add support for looking for tracebacks in Issues via the 'tbgrep' module.
|
ping @resmo |
|
Hi @alikins, been too busy last week, I will get feedback by the end of this week. Thanks! |
|
@alikins thank you for this, it helped inspire some of my code. |
|
\m/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds like there is other ongoing work to do this, so this is not ready or likely to be merged, but figured a PR for reference wouldn't hurt.
This is incomplete, and not well tested. I've only ever ran it in '--dry-run' mode, so only the read-only parts of triage.py have been tested at all. I added some TODO's and notes in the code referencing unfinished bits.
The main change was adding an Issue and a TriageIssue class, and some reorganization of the existing
PullRequest and Triage class to share some code with the new glass and some light generalization.
Also added the aforementioned '--dry-run' mode since I didn't want to accidentally munge 'live' prs.