Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pykerberos #169

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Add pykerberos #169

merged 2 commits into from
Feb 7, 2023

Conversation

it-pappa
Copy link
Contributor

@it-pappa it-pappa commented Feb 6, 2023 •
edited by shanemcd
Loading

Added pykerberos

@it-pappa it-pappa mentioned this pull request Feb 6, 2023
Closed
shanemcd
shanemcd reviewed Feb 6, 2023
View reviewed changes
_build/requirements.txt Outdated Show resolved Hide resolved
@shanemcd shanemcd changed the title Update requirements.txt Add pykerberos Feb 7, 2023
relrod
relrod approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@relrod relrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @it-pappa

@relrod relrod enabled auto-merge (squash) February 7, 2023 19:58
@relrod relrod disabled auto-merge February 7, 2023 20:07
@relrod
Copy link
Member

relrod commented Feb 7, 2023 •
edited
Loading

Bah, CI failed for a different reason that time.

@it-pappa I believe we'll need krb5-devel added to bindep.txt in the same directory to get this passing. (Make it look like the other lines in that file)

I'll add the dep, so we can get this merged.

it-pappa and others added 2 commits February 7, 2023 14:32
@it-pappa @relrod
Add pykerberos
70a3807
@relrod
Add krb5-devel dep
2fe0bf6 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod merged commit 66054c7 into ansible:devel Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relrod relrod relrod approved these changes

@shanemcd shanemcd shanemcd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@it-pappa @relrod @shanemcd