Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop window resizing in e2e tests (and possibly other tests) and set this in driver options #2426

Closed
dsesami opened this issue Oct 12, 2018 · 1 comment
Closed

Drop window resizing in e2e tests (and possibly other tests) and set this in driver options #2426

dsesami opened this issue Oct 12, 2018 · 1 comment
Assignees
@elyezer
Labels
component:ui type:enhancement

Comments

@dsesami
Copy link
Contributor

dsesami commented Oct 12, 2018

ISSUE TYPE
  • Enhancement
COMPONENT NAME
  • UI
SUMMARY

There's a lot of this in the UI testing code:
client.resizeWindow(1200,800);
We should drop these where possible and set this in the driver options on initialization.
@dsesami dsesami mentioned this issue Oct 12, 2018
Merged
rooftopcellist pushed a commit to rooftopcellist/awx that referenced this issue Oct 15, 2018
@marshmalien
Merge pull request ansible#2426 from marshmalien/fix/1521-templates-d…
f6c48bc 
…ismiss-button

Hide dismiss button on the templates list panel
@elyezer elyezer self-assigned this May 22, 2019
@elyezer elyezer mentioned this issue May 22, 2019
Merged
@elyezer
Copy link
Member

elyezer commented Jun 3, 2019

Window size is defined globally by #3941. We couldn't use a single resolution for all tests so we tweaked some of then to resize on #3979. With those PRs, we can close this issue.

@elyezer elyezer closed this as completed Jun 3, 2019
@dependabot dependabot bot mentioned this issue Aug 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elyezer elyezer

Labels
component:ui type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elyezer @dsesami