Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lock to cachetools usage #11373

Merged

Commits on May 6, 2022

  1. add lock to cachetools usage

    * We observed daphne giving tracebacks when accessing logging settings.
      Originally, configure tower in tower settings was no a suspect because
      daphne is not multi-process. We've had issues with configure tower in
      tower settings and multi-process before. We later learned that Daphne
      is multi-threaded. Configure tower in tower was back to being a
      suspect. We constructed a minimal reproducer to show that multiple
      threads accessing settings can cause the same traceback that we saw in
      daphne. See
      https://gist.github.com/chrismeyersfsu/7aa4bdcf76e435efd617cb078c64d413
      for that recreator. These fixes stop the recreation.
    chrismeyersfsu authored and rebeccahhh committed May 6, 2022
    Configuration menu
    Copy the full SHA
    21972c9 View commit details
    Browse the repository at this point in the history