Make sure to fire off failure notifications on error

[jbradberry]

SUMMARY

where the error is unrelated to Ansible, thus is not caught by the
usual methods.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• API

AWX VERSION

ADDITIONAL INFORMATION

[jbradberry]

@chrismeyersfsu The one thing I'm worried about in this PR is if there are circumstances where an error result can cause the notification templates fire off by this path and the more usual path. Any thoughts?

[chrismeyersfsu]

That's a good thing to be worried about @jbradberry . Do we call handle_success_and_failure_notifications anywhere else?

[sarabrajsingh]

That's a good thing to be worried about @jbradberry . Do we call handle_success_and_failure_notifications anywhere else?

@chrismeyersfsu the other calls to handle_success_and_failure_notifications are done in callback.py and events.py but aren't directly involved in firing off notifications when jobs fail. this is done at the tasks.py level

[AlanCoding]

I didn't understand #8771 before, but I might be seeing it now.

Either way, this seems fairly correct on its own. The speculated problem here seems to be the mutual exclusivity of the error status and the EOF message. While it could possibly happen, that doesn't sound highly credible to me.

[AlanCoding]

I just realized that we don't want job_explanation to read

Job terminated due to error

This is particularly bad in the cases where an error occurred and job_explanation was set to something in response to that. This code would overwrite that useful message with this vague one.