Modifying schedules API to allow for rrulesets #5733 #12043
Conversation
john-westcott-iv
force-pushed
the
rrulesets
branch
from
dd045bf
to
3379cb7
Compare
john-westcott-iv
force-pushed
the
rrulesets
branch
from
a8ff45d
to
fdc5898
Compare
|
@john-westcott-iv there is a JS lint failure. From the ui dir, |
|
I would like to see some docs with this to get the ball rolling. |
john-westcott-iv
force-pushed
the
rrulesets
branch
from
7528544
to
098eff9
Compare
awx_collection/tests/integration/targets/lookup_rruleset/tasks/main.txt
Outdated
Show resolved
Hide resolved
docs/schedules.md
Outdated
| * The use of `FREQ=BYWEEKNO` in an `RRULE` | ||
| * The use of `COUNT=` in an `RRULE` with a value over 999 | ||
|
|
||
| * At least one RRULE must be in the string |
There was a problem hiding this comment.
A little confused - isn't this a list of things that are not supported? This looks like a true statement.
There was a problem hiding this comment.
The wording here has been updated.
|
|
||
| DTSTART:20191219T130551Z RRULE:FREQ=MONTHLY;INTERVAL=1;BYDAY=SA;BYMONTHDAY=12,13,14,15,16,17,18 | ||
|
|
||
|
|
There was a problem hiding this comment.
👍 great example content, thanks for adding those.
There was a problem hiding this comment.
I'll be adding these to the unit tests as well.
john-westcott-iv
force-pushed
the
rrulesets
branch
from
6f2d150
to
f09f35a
Compare
|
@nixocio what's the state of this issue?
With the UI changes you added, is this now a problem? (I read it that you can set "until" constraints in the UI that the API will choke on) EDIT: never mind, I realize there isn't really UI work done yet. |
john-westcott-iv
force-pushed
the
rrulesets
branch
from
f09f35a
to
990f4f4
Compare
Changing rrule validation to allow for multuipe BYMONTH, BYMONTHDAY, BYYEARDAY and BYYEARDAY Modified validation to inspect for SECONDLY at the rule level and now returning a list of all errors instead of the first encounterd Fixed some linting in the rruleset test modules
john-westcott-iv
force-pushed
the
rrulesets
branch
from
990f4f4
to
065e7e6
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
SUMMARY
Modifies the code to allow for more complex rrulesets instead of just a single RRULE.
You can add multiple RRULEs in addition to EXRULES (exclude rules).
However, this does not include support for DATES and EXDATES.
NOTE: There is one piece (the until property) that will need additional changes in the future when the UI also updates. For now, we left the until computation alone which returns the first until found in the ruleset. Once the UI work starts we will need to determine if this returns an array of untils or if this property goes away and the until's will be computed on the client side while processing the ruleset.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION