Persistent list filters #12229
Persistent list filters #12229
Conversation
| @@ -39,7 +43,7 @@ function RoutedTabs({ tabsArray }) { | |||
| aria-label={typeof tab.name === 'string' ? tab.name : null} | |||
| eventKey={tab.id} | |||
| key={tab.id} | |||
| link={tab.link} | |||
| href={`#${tab.link}`} | |||
There was a problem hiding this comment.
This is a bit quirky... help the URL appear correctly while mousing over the link.
Ideally, I'd like to remove the hash from URLs entirely to make this unnecessary, but it may be too late for that
| import { useEffect } from 'react'; | ||
| import { useLocation, useHistory } from 'react-router'; | ||
|
|
||
| const STORAGE_KEY = 'persistentFilter'; |
There was a problem hiding this comment.
We could move this one to the constant file. Also, the other constants used on session storage starts with awx to make ease to identify them, and avoid name collision.
| @@ -78,7 +79,9 @@ function Templates() { | |||
| </Route> | |||
| <Route path="/templates"> | |||
| <PageSection> | |||
| <TemplateList /> | |||
| <PersistentFilters pageKey="templates"> | |||
There was a problem hiding this comment.
I noticed a delay in certain pages to filter be evaluated using firefox, on chrome seems to be more responsive.
filter.mov
There was a problem hiding this comment.
hey @keithjgrant, excellent work. There is an issue on awx/devel once an user, lets say User A is logged out, another User b logging in back the User B will be redirect to where the URL where User A left. This issue was not introduced by this PR, but saving the filters will redirect to the previous saved filter. This issue could be addressed by #11167
keithjgrant
force-pushed
the
5688-persistent-filters
branch
from
3dd2236
to
ddbe1d0
Compare
keithjgrant
force-pushed
the
5688-persistent-filters
branch
from
ddbe1d0
to
b8becbf
Compare
* add PersistentFilters component * add PersistentFilters test * add persistent filters to all list pages * update tests * clear sessionStorage on logout * fix persistent filter on wfjt detail; cleanup
SUMMARY
Keeps any list search/pagination filters in place when clicking the "Back to XXX" button. Applies to all top-level list pages except Schedules page.
This also updates
RoutedTabsto use the properhrefprop on each tab, so URLs show as expected in the browser while hovering mouse over the tabs.ISSUE TYPE
COMPONENT NAME