Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix websockets when application is served from a non-root path #12242

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix websockets when application is served from a non-root path #12242

merged 1 commit into from
Feb 23, 2023

Conversation

adpavlov
Copy link

@adpavlov adpavlov commented May 17, 2022 •
edited by shanemcd

… to fix #12241

Signed-off-by: Alexander Pavlov alexander.pavlov@amdocs.com

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
SUMMARY
ISSUE TYPE
  • Feature Pull Request
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
  • API
  • UI
  • Collection
AWX VERSION
ADDITIONAL INFORMATION

@AlanCoding AlanCoding requested a review from shanemcd June 1, 2022 15:06
@TheRealHaoLiu
Copy link
Member

@adpavlov thanks for the submission of this PR we are looking reviewing and testing it now.

If you can provide a bit more detail on how to reproduce the issue and how to test the solution it will greatly speed up our effort.

also are you in our Matrix chatroom? https://matrix.to/#/#awx:ansible.com come hang out with bunch of other people that are passionate about AWX!

@adpavlov
Copy link
Author

@adpavlov thanks for the submission of this PR we are looking reviewing and testing it now.

If you can provide a bit more detail on how to reproduce the issue and how to test the solution it will greatly speed up our effort.

also are you in our Matrix chatroom? https://matrix.to/#/#awx:ansible.com come hang out with bunch of other people that are passionate about AWX!

Hi @TheRealHaoLiu I think I described everything in issue itself #12241
Have you had a look on it?

@john-westcott-iv john-westcott-iv added the community pull request Applied to community based pull requests for filtering label Jan 20, 2023
@shanemcd
Remove trailing $ from websocket_urlpatterns to work with custom path…
5e28f5d 
… to fix ansible#12241

Signed-off-by: Alexander Pavlov <alexander.pavlov@amdocs.com>
@shanemcd shanemcd changed the title Remove trailing $ from websocket_urlpatterns to work with custom path… Fix websockets when application is served from a non-root path Feb 23, 2023
@shanemcd shanemcd merged commit f4bcc03 into ansible:devel Feb 23, 2023
@john-westcott-iv john-westcott-iv mentioned this pull request Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanemcd shanemcd shanemcd approved these changes

Assignees
No one assigned
Labels
community pull request Applied to community based pull requests for filtering community component:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Websocket not working at non-root path
4 participants
@adpavlov @TheRealHaoLiu @shanemcd @john-westcott-iv