Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of PR of Jinga 2 Rendering #12306

Conversation

djyasin
Copy link
Member

@djyasin djyasin commented Jun 1, 2022

Cherry picked changes to merge community PR. #11366

Switch Jinja2 environment for rendering before testing JSON to ImmutbleSandboxedEnvironment

Render Jinja template before checking for valid JSON

SUMMARY

original issue: #10961

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • API
AWX VERSION
awx: 21.0.1

…bleSandboxedEnvironment

Render Jinja template before checking for valid JSON
@djyasin djyasin linked an issue Jun 1, 2022 that may be closed by this pull request
3 tasks
@djyasin djyasin self-assigned this Jun 1, 2022
Copy link
Member

@jbradberry jbradberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, and I see that Chris and @AlanCoding weighed in on the original community PR. 👍

@cypress
Copy link

cypress bot commented Jun 7, 2022



Test summary

637 1 821 0Flakiness 4


Run details

Project AWX - Functional
Status Failed
Commit 8a5e89e
Started Jun 13, 2022 3:43 PM
Ended Jun 13, 2022 5:45 PM
Duration 01:19 💡
OS Linux Debian - 11.3
Browser Chrome 99

View run in Cypress Dashboard ➡️


Failures

cypress/integration/inventories/inventory-group-list.spec.js Failed
1 Inventory Tab - Multiple Groups > can sort inventory groups

Flakiness

dashboard/dashboard.spec.js Flakiness
1 Dashboard Job Status Graph - Real > Can modify Job Status Period to past 2 weeks
workflow-approvals/workflow-approvals-operations.spec.js Flakiness
1 Workflow approvals - Details > can approve a workflow
workflows/workflow-visualizer/workflow-viz-jt-node-prompt-and-survey.spec.js Flakiness
1 Job template node within a workflow > can prompt and survey against a job template node and save
job-templates/job-template-crud.spec.js Flakiness
1 Job Templates- Run > JT can be executed with a specific EE coming from the organization

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jay-steurer
Copy link
Contributor

Tested and approved

@jay-steurer jay-steurer merged commit ea3a8d4 into devel Jun 13, 2022
@TheRealHaoLiu TheRealHaoLiu deleted the 10961-webhook-notification-does-not-allow-for-use-of-jinja-statements branch February 8, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook Notification does not allow for use of Jinja Statements
5 participants