Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logout/login redirect for different users #12312

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

nixocio
Copy link
Contributor

@nixocio nixocio commented Jun 2, 2022

  • Logout as User A and Login as User B redirects to /home
  • Logout as User A and Login as User A redirects to /home
  • Allow session to timeout as User A and Login as User A redirects to User A's last location

In order to test this change session to expire in Idle Time Force Log Out to be 61s. Create 2 users, A and B.

image

See: #11167

@nixocio nixocio force-pushed the ui_issue_11167_rebased branch 3 times, most recently from 6ed2755 to da80c6b Compare June 2, 2022 14:45
@nixocio nixocio requested a review from AlexSCorey June 2, 2022 14:47
@nixocio nixocio force-pushed the ui_issue_11167_rebased branch 2 times, most recently from a8f8f57 to 21813cf Compare June 2, 2022 15:16
awx/ui/src/util/auth.js Outdated Show resolved Hide resolved
awx/ui/src/screens/Login/Login.js Outdated Show resolved Hide resolved
@nixocio nixocio force-pushed the ui_issue_11167_rebased branch 3 times, most recently from ae03c3c to cde558c Compare June 2, 2022 19:46
* Logout as User A and Login as User B redirects to `/home'
* Logout as User A and Login as User A redirects to `/home'
* Allow session to timeout as User A and Login as User A redirects to User A's last location

See: ansible#11167
@cypress
Copy link

cypress bot commented Jun 7, 2022



Test summary

628 0 828 0Flakiness 6


Run details

Project AWX - Functional
Status Passed
Commit d803761
Started Jun 13, 2022 3:25 PM
Ended Jun 13, 2022 5:13 PM
Duration 48:19 💡
OS Linux Debian - 11.3
Browser Chrome 99

View run in Cypress Dashboard ➡️


Flakiness

credentials/credential-crud.spec.js Flakiness
1 Create and delete Credentials > Can create, edit, and delete Google Compute Engine credential using required fields
dashboard/dashboard.spec.js Flakiness
1 Dashboard Counts button - Inventories > Dashboard Counts button for Inventories shows correct count and navigates correctly when clicked
hosts/hosts-lists.spec.js Flakiness
1 Host list > can perform advanced search
inventories/inventory-host-operations.spec.js Flakiness
1 Inventory Host list- Operations > can sort hosts by name after performing advanced search
workflows/workflow-visualizer/workflow-viz-wfjt-node-prompt-and-survey.spec.js Flakiness
1 Workflow node within a workflow > can prompt and survey against a workflow node with empty visualizer and save
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@nixocio nixocio requested a review from kialam June 8, 2022 17:39
@akus062381 akus062381 self-assigned this Jun 13, 2022
Copy link
Member

@akus062381 akus062381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@nixocio nixocio merged commit 9b0a2b0 into ansible:devel Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants