Fix workflow job template webhook credential bug #12325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-westcott-iv
approved these changes
Jun 8, 2022
john-westcott-iv
added
component:awx_collection
jbradberry
approved these changes
Jun 9, 2022
|
@Tompage1994 Thanks for your contribution. We are going to confirm we have tests which will pickup on this bug to make sure we don't end up with a regression in the future. Once those test are defined we will get this merged. |
|
Validated with a test on #12468 |
|
@Tompage1994 hey, could you rebase your branch using ansible/devel one? From QE we are having some issues due to the misalignment between your branch and devel. Thanks! |
Signed-off-by: tompage1994@hotmail.co.uk <tpage@redhat.com>
Tompage1994
force-pushed
the
wfjt_webhook_cred_fix
branch
from
28007a6
to
a299316
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tompage1994@hotmail.co.uk tpage@redhat.com
SUMMARY
related #12324
Fixes issue in
awx.awx.workflow_job_templatewherewebhook_credentialoption was not working because the api/api/v2/webhook_credentialdoes not exist.ISSUE TYPE
COMPONENT NAME
AWX VERSION