-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column to display resource related to a schedule #12360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing is broken but I wanted to bring something to your attention-
when a user creates a schedule inside a project or a job template, and they click the link to those resources from the list of schedules, it navigates to the detail pages for those resources.
but- when a user clicks the resource link to a management job from the list of schedules, it doesn't navigate to the details page for that management job. it navigates to the list of management jobs.
So technically there isn't anything wrong, but perhaps for continuity, you could have them work the same way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Lets improve the UX by adding sort functionality for the new column.
@akus062381, good observation. However management jobs do not have a details page. That is why. |
Add column to display what resource is related to a schedule See: ansible#5012
@AlexSCorey , PR updated ready to be reviewed again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Add column to display what resource is related to a schedule
This change was added based on the feedback from @trahman73 .
See: #5012