Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column to display resource related to a schedule #12360

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

nixocio
Copy link
Contributor

@nixocio nixocio commented Jun 10, 2022

Add column to display what resource is related to a schedule

This change was added based on the feedback from @trahman73 .

image

See: #5012

@nixocio nixocio requested a review from AlexSCorey June 13, 2022 13:20
@akus062381 akus062381 self-assigned this Jun 13, 2022
@cypress
Copy link

cypress bot commented Jun 13, 2022



Test summary

621 7 828 0Flakiness 9


Run details

Project AWX - Functional
Status Failed
Commit 269fb75
Started Jun 13, 2022 4:31 PM
Ended Jun 13, 2022 9:20 PM
Duration 49:26 💡
OS Linux Debian - 11.3
Browser Chrome 99

View run in Cypress Dashboard ➡️


Failures

job-templates/job-template-surveys.spec.js Failed
1 Surveys- List > can navigate back to survey list from breadcumb
job-templates/job-template-tabs.spec.js Failed
1 Job Templates Tab- Schedules > Can add prompted fields and survey to a scheduled JT
inventories/inventory-host-operations.spec.js Failed
1 Inventory Host list- Operations > can sort hosts by name after performing advanced search
2 Inventory Host list- Operations > can delete a host from the details view
credentials/credential-list.spec.js Failed
1 Sort by name > can sort credentials by name after performing basic search
projects/project-crud.spec.js Failed
1 Delete Project > can delete a project and see all dependencies related to this project
workflows/workflow-prompts-and-surveys.spec.js Failed
1 Survey form > can add all survey type and launch a wfjt

Flakiness

notifications/notification-operations.spec.js Flakiness
1 Notification test > Can launch a notification bell test
jobs/job-list.spec.js Flakiness
1 Search operations - Jobs > can perform basic search for Jobs by Name
job-templates/job-template-list.spec.js Flakiness
1 Job Template Operations- Webhooks > can enable webhooks
2 Workflow Job Template Operations- Search > can perform basic search by Type for WFJT by Name
notifications/notification-crud.spec.js Flakiness
1 Create a notification > Can create a notification template for email
This comment includes only the first 5 flaky tests. See all 9 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@akus062381 akus062381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing is broken but I wanted to bring something to your attention-

when a user creates a schedule inside a project or a job template, and they click the link to those resources from the list of schedules, it navigates to the detail pages for those resources.
but- when a user clicks the resource link to a management job from the list of schedules, it doesn't navigate to the details page for that management job. it navigates to the list of management jobs.
So technically there isn't anything wrong, but perhaps for continuity, you could have them work the same way?

Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Lets improve the UX by adding sort functionality for the new column.

@nixocio
Copy link
Contributor Author

nixocio commented Jun 13, 2022

nothing is broken but I wanted to bring something to your attention-

when a user creates a schedule inside a project or a job template, and they click the link to those resources from the list of schedules, it navigates to the detail pages for those resources. but- when a user clicks the resource link to a management job from the list of schedules, it doesn't navigate to the details page for that management job. it navigates to the list of management jobs. So technically there isn't anything wrong, but perhaps for continuity, you could have them work the same way?

@akus062381, good observation. However management jobs do not have a details page. That is why.

Add column to display what resource is related to a schedule

See: ansible#5012
@nixocio
Copy link
Contributor Author

nixocio commented Jun 14, 2022

@AlexSCorey , PR updated ready to be reviewed again.

Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AlexSCorey AlexSCorey merged commit 59691b7 into ansible:devel Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants