Adding GOOGLE_APPLICATION_CREDENTIALS env var #12389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Per my understanding of #12211 the
gcloudexecutable requires an environment variable ofGOOGLE_APPLICATION_CREDENTIALSpointing to the same file that we currently pointGCE_CREDENTIALS_FILE_PATHtoo. This will allow ashellmodule call togcloudto function with aGoogle Compute Enginecredential type.I am looking for someone with more Google Cloud experience than me to confirm that the two file syntaxes are the same and also that adding this additional variable will not have an ill effect on the modules or anything else. In the man time, this PR can be tested.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION