-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do the grafana thing in docker-compose templating itself #12391
Conversation
One issue I've had is tearing down gafana/prometheus to start over if I've changed the scrape config. not sure we have a make docker-compose-clean target for awx either though, so its not like that is a regression |
I pushed another change that adds the volumes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with that addition I say
container_name: tools_grafana_1 | ||
hostname: splunk | ||
ports: | ||
- "3001:3000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for those wondering, I found that 3000 was conflicting with docker engine on my local machine, but which is why 3001 was chosen.
SUMMARY
I'm following the pattern started by @john-westcott-iv here, and I find it vastly better quality-of-life than the existing idea of starting up independent containers.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
So far tested and works great