Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do the grafana thing in docker-compose templating itself #12391

Merged
merged 7 commits into from
Jun 16, 2022

Conversation

AlanCoding
Copy link
Member

SUMMARY

I'm following the pattern started by @john-westcott-iv here, and I find it vastly better quality-of-life than the existing idea of starting up independent containers.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API
  • Other
ADDITIONAL INFORMATION

So far tested and works great

PROMETHEUS=true GRAFANA=true MAIN_NODE_TYPE=hybrid EXECUTION_NODE_COUNT=0 COMPOSE_TAG=devel make docker-compose

@kdelee
Copy link
Member

kdelee commented Jun 16, 2022

One issue I've had is tearing down gafana/prometheus to start over if I've changed the scrape config. not sure we have a make docker-compose-clean target for awx either though, so its not like that is a regression

@AlanCoding
Copy link
Member Author

I pushed another change that adds the volumes to make docker-clean-volumes, so I think this should address that concern.

Copy link
Member

@rebeccahhh rebeccahhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with that addition I say :shipit:

container_name: tools_grafana_1
hostname: splunk
ports:
- "3001:3000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for those wondering, I found that 3000 was conflicting with docker engine on my local machine, but which is why 3001 was chosen.

@AlanCoding AlanCoding merged commit 923cc67 into ansible:devel Jun 16, 2022
@AlanCoding AlanCoding deleted the compose_graphs branch June 24, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants