Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a failure message to job output when job failed and no events exist #12412

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

AlexSCorey
Copy link
Member

SUMMARY

This addresses #11994

ISSUE TYPE
  • Bug or Docs Fix
COMPONENT NAME
  • UI

@akus062381 akus062381 self-assigned this Jun 23, 2022
@AlanCoding
Copy link
Member

I thought I would try to test this, but make ui-devel is giving me this which seems to be fatal.

Creating an optimized production build...
Failed to compile.

src/screens/Job/JobOutput/EmptyOutput.js
  Line 10:10:  'LaunchButton' is defined but never used      no-unused-vars
  Line 10:24:  'ReLaunchDropDown' is defined but never used  no-unused-vars

Search for the keywords to learn more about each error.

@AlexSCorey
Copy link
Member Author

@AlanCoding I fixed that problem. You can try again.

@AlanCoding
Copy link
Member

Yes, make ui-devel works now, but it doesn't seem to be giving me what I expected.

Screenshot from 2022-06-28 11-33-39

It seems perfectly fine to tell me to navigate to Details, but this shows a {0} that looks unintended.

this job has this text from a prior WIP of mine (this exact messages won't be used in practice)

    "job_explanation": "Task was stopped due to a service disruption.",

@AlexSCorey
Copy link
Member Author

@AlanCoding
Screen Shot 2022-06-28 at 6 31 11 PM

@AlanCoding
Copy link
Member

seems to be working for my example now

Screenshot from 2022-06-29 11-14-05
Screenshot from 2022-06-29 11-14-05

@AlexSCorey AlexSCorey merged commit ff882a3 into ansible:devel Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants