Updated setup.py --version to python3 -m setuptools_scm. #12428
Conversation
|
This is a PR in progress. Since these changes will touch multiple areas and require additional dependencies, we have decided to incrementally make commits as we update each term. This PR specifically updates: setup.py --version |
|
Updated setup.py --version in this WIP PR. Given the scope of this change, we have opted to incrementally commit updates here as we find replacements for the deprecated terminology. |
shanemcd
force-pushed
the
updating_setuppy
branch
2 times, most recently
from
137a2de
to
d5a440a
Compare
shanemcd
force-pushed
the
updating_setuppy
branch
from
d5a440a
to
cbea367
Compare
|
@Zokormazo The Makefile is used within the Dockerfile to create /var/lib/awx/venv, so we know it will always get created with the intended version. For the build playbook - I think python3 is fine there because it's only grabbing the version. I dont see a reason to tie this to a particular python version. For the Dockerfile - I think it's fine because we know within the context of EL9 that will always be 3.9. |
|
|
||
| def version_file(): | ||
| current_dir = os.path.dirname(os.path.abspath(__file__)) | ||
| version_file = os.path.join(current_dir, '..', 'VERSION') |
There was a problem hiding this comment.
What lays down this version file and what's the expectation for using the development environment? Will it have a version file or not?
There was a problem hiding this comment.
The VERSION file is only expected to be present downstream. The development environment should use setuptools_scm.get_version(), which will get the version based on the most recent git tag.
SUMMARY
Invoking setup.py directly is deprecated #12375
ISSUE TYPE
COMPONENT NAME
AWX VERSION