Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added domain entry and authorizer for TSS #12627

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

vician
Copy link
Contributor

@vician vician commented Aug 5, 2022

SUMMARY

Adding domain option to Thycotic SecretServer credential plugin.

We hope this would get into Ansible Automation Platform as well.

ISSUE TYPE
  • Enhanced Feature
  • New or Enhanced Feature
COMPONENT NAME

awx/main/credential_plugins/tss.py

AWX VERSION
21.4.0
ADDITIONAL INFORMATION

It's very similar to approach of community.general.tss here ansible-collections/community.general#3228

@vician vician changed the title Added domain item and authorizer for TSS Added domain entry and authorizer for TSS Aug 5, 2022
@vician
Copy link
Contributor Author

vician commented Sep 5, 2022

How can we get this reviewed please?

@john-westcott-iv
Copy link
Member

Our apologies for the delay. I am going to close and reopen this PR to see if I can get the checks to properly run.

@vician
Copy link
Contributor Author

vician commented Sep 14, 2022

Thank you. Pipeline is passing.

@thedoubl3j
Copy link
Member

We hope this would get into Ansible Automation Platform as well.

Hey @vician do you have any contacts for Integrations at Thycotic/Delinea that can reach out to the Ansible partners team? Getting this integration (and future ones) in front of them will better position this PR to get downstream.

@vician
Copy link
Contributor Author

vician commented Sep 30, 2022

@thedoubl3j How can they reach Ansible partners team, please?

@thedoubl3j
Copy link
Member

@vician ansiblepartners@redhat.com is the alias for the team.

@john-westcott-iv john-westcott-iv added the community pull request Applied to community based pull requests for filtering label Jan 20, 2023
@obaranov
Copy link
Contributor

obaranov commented Apr 13, 2023

@vician I failed to verify plugin with the our secretservercloud server. I have a local user configured there. When I click Test, I'm getting ClientError:

image

I'm using docker development environment. Got this log:

tools_awx_1 | awx-uwsgi stderr | 2023-04-13 17:30:33,931 WARNING  [4f08de1e] awx.api.generics status 400 received by user obaranov attempting to access /api/v2/credentials/84/test/ from 172.18.0.1
tools_awx_1 | awx-uwsgi stderr | 
tools_awx_1 | awx-uwsgi stderr | 2023-04-13 17:30:33,939 WARNING  [4f08de1e] django.request Bad Request: /api/v2/credentials/84/test/
tools_awx_1 | awx-uwsgi stderr | 2023-04-13 17:30:33,939 WARNING  [4f08de1e] django.request Bad Request: /api/v2/credentials/84/test/
tools_awx_1 | awx-uwsgi stderr | 
tools_awx_1 | awx-uwsgi stderr | [pid: 389|app: 0|req: 8/42] 172.18.0.1 () {60 vars in 1173 bytes} [Thu Apr 13 17:30:33 2023] POST /api/v2/credentials/84/test/ => generated 36 bytes in 466 msecs (HTTP/1.1 400) 16 headers in 621 bytes (1 switches on core 0)
tools_awx_1 | awx-uwsgi stderr | 

I tested the same URL, username and password with the ansible lookup plugin. And it worked:

  - debug:
      msg: "{{
              lookup(
                  'community.general.tss',
                  3,
                  base_url=base_url,
                  username=username,
                  password=password,
                  domain=''
              )
          }}"
          ```
          
Any ideas what could be wrong?           

@vician
Copy link
Contributor Author

vician commented Apr 18, 2023

@obaranov i don’t think your issue is related to this pull request. The whole integration is outdated. I might find some more time to open new PR for that but I don’t have environment to test the changes at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community pull request Applied to community based pull requests for filtering community component:api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants