Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles workflow node schema inventory #12721

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

db0
Copy link
Contributor

@db0 db0 commented Aug 23, 2022

SUMMARY

This makes the workflow_job_template handle the inventory passed to nodes in the schema properly

This is handled fine in workflow_job_template_node, but since workflow_job_template is using its own function, this functionality is missing. I simply copied the same approach from workflow_job_template_node and tested that it is working in my installation

Related #12720

ISSUE TYPE

Bug

COMPONENT NAME

Collection

AWX VERSION
I am using the Ansible Automation Platform 2.2.0 from RedHat, not AWX

Bug, Docs Fix or other nominal change

@github-actions github-actions bot added the component:awx_collection issues related to the collection for controlling AWX label Aug 23, 2022
Copy link
Contributor

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@john-westcott-iv
Copy link
Member

Thanks for your contribution. We have put this in our backlog to get tested and merged in. While you are waiting for the testing process please feel free to reach out to us on Matrix in the #ansible-awx channel.

@sean-m-sullivan
Copy link
Contributor

@john-westcott-iv think this got lost in the backlog, just pinging to see about putting in qa teams queue

@jay-steurer jay-steurer self-requested a review January 16, 2023 15:56
@jay-steurer
Copy link
Contributor

@db0 Could you rebase the PR? Thanks!

@db0
Copy link
Contributor Author

db0 commented Jan 18, 2023

@jay-steurer done

@jay-steurer jay-steurer merged commit e9ad01e into ansible:devel Jan 19, 2023
@jay-steurer
Copy link
Contributor

Verified by QE. Merging it.

@db0 db0 deleted the workflow_node_inventory branch January 20, 2023 09:13
@john-westcott-iv john-westcott-iv added the community pull request Applied to community based pull requests for filtering label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community pull request Applied to community based pull requests for filtering community component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants