Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule exceptions #12778

Merged
merged 9 commits into from Sep 15, 2022
Merged

Conversation

keithjgrant
Copy link
Member

@keithjgrant keithjgrant commented Aug 29, 2022

SUMMARY

Adds exception options to schedule form.

Addresses #12542

Screen Shot 2022-08-29 at 1 44 59 PM

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • UI

Copy link
Member

@kialam kialam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down and tested it locally. Works as expected 👍 .

@jay-steurer jay-steurer self-requested a review September 6, 2022 13:00
@cypress
Copy link

cypress bot commented Sep 6, 2022



Test summary

121 10 13 0


Run details

Project AWX - Functional
Status Failed
Commit 078c3ae
Started Sep 9, 2022 1:51 PM
Ended Sep 9, 2022 3:57 PM
Duration 05:54 💡
OS Linux Debian - 11.3
Browser Chrome 100

View run in Cypress Dashboard ➡️


Failures

components/tooltips.cy.js Failed
1 Inventory source form > Update on launch option tooltip should display correctly
screens/activity-stream/activity-stream.cy.js Failed
1 Visual Testing - Activity Stream > Activity Stream Empty Search
screens/dashboard/dashboard.cy.js Failed
1 Dashboard > Can view Recent Templates
screens/jobs/jobs.cy.js Failed
1 Job output > Job output
screens/notification-templates/notifications-templates.cy.js Failed
1 Notification test > can show a notification toast with state timeout
screens/projects/projects.cy.js Failed
1 Visual Testing - Project Page > Project tabs
screens/schedules/schedules.cy.js Failed
1 Visual Testing - Schedules > Schedules details and edit
screens/settings/settings.cy.js Failed
1 Settings > User Interface > User Interface settings
screens/templates/job-templates.cy.js Failed
1 Job template list, details and edit > Templates list, template details, template edit
screens/workflow-approval/workflow-approval.cy.js Failed
1 Visual Testing - Workflow approval > Workflow approval list > Workflow approval list and details

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@AlexSCorey
Copy link
Member

Good to go re: testing though does have some performance improvements needed.

@keithjgrant
Copy link
Member Author

Not ready for final dev review/merging yet. Working through performance issues on the schedule exceptions validation

@keithjgrant
Copy link
Member Author

ready for re-review

@jay-steurer
Copy link
Contributor

Performance has increased. Ready to merge.

@akus062381
Copy link
Member

akus062381 commented Sep 15, 2022

triggered another test run: Yolo 444

Copy link
Member

@mabashian mabashian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@akus062381
Copy link
Member

the failures that happened in the Jenkins run are not because of the changes on this PR. approved!

@akus062381 akus062381 merged commit 9df447f into ansible:devel Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants