Fix gap between API-loaded job events and WS-streamed events #13075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akus062381
reviewed
Nov 1, 2022
keithjgrant
force-pushed
the
13059-running-job-output-gap
branch
from
04b6063
to
03b0281
Compare
akus062381
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes occasional bug where a gray loading bar appears between job events loaded via API and those streamed over websockets. When the first events stream over websockets, the page will now re-load the prior events from the API, updating them and the
remoteRowCountto ensure accuracy.I also fixed an off-by-one error that sometimes made the last API-fetched event not render even if it is already available in memory.
Addresses #13059
This bug generally only presents itself when the initial load of the job or its events via API takes too long to resolve, and already-completed events are missing from the fetched results. I was able to reproduce it with ~50% frequency by manually delaying the response when fetching the job object.
ISSUE TYPE
COMPONENT NAME