Prepopulates job template form with related resource #13262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSCorey
force-pushed
the
12429-PrepopulateResources
branch
from
8e7d8a2
to
382479c
Compare
| 'vault', | ||
| 'kubernetes', | ||
| 'cryptography', | ||
| ]; |
There was a problem hiding this comment.
Curious, how is this list determined?
There was a problem hiding this comment.
Job templates only support certain types of credentials and the api doesn't have a way of telling the UI, which types are JTs support so the UI has the be the source of truth for that information.
AlexSCorey
force-pushed
the
12429-PrepopulateResources
branch
from
382479c
to
51ef1e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This addresses #12429
When in
/credentials/id/job_templatesor in inventories/id/job_templates`. If the user clicks Add they are navigated to the Job Template Add form. This change now prepopulates the resource, from which the user came, in the appropriate field in the form. All of that info about the related resource is passed through to the job template form via a querystring in the url.There is 1 notable change here. Not all credentials can be a part of a job template. Therefore, we now add the Job Templates tab to ONLY those credentials whose
kindis able to be added to a job template.This functionality already exists for projects.
Users cannot add job templates from /instange_groups/id, or execution_environments/id as those resources do not have a job templates tab.
ISSUE TYPE
COMPONENT NAME