Update to comply with new black rules #13502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
commented
Feb 1, 2023
| @@ -128,7 +128,7 @@ def get_field_info(self, field): | |||
| # Special handling of notification configuration where the required properties | |||
| # are conditional on the type selected. | |||
| if field.field_name == 'notification_configuration': | |||
| for (notification_type_name, notification_tr_name, notification_type_class) in NotificationTemplate.NOTIFICATION_TYPES: | |||
| for notification_type_name, notification_tr_name, notification_type_class in NotificationTemplate.NOTIFICATION_TYPES: | |||
There was a problem hiding this comment.
this makes me uncomfortable
There was a problem hiding this comment.
Never mind, I think I've convinced myself that since this is a for, it really is standard practice to not use (). The behavior is the same in either case.
gamuniz
approved these changes
Feb 1, 2023
|
SHIP IT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Failing checks on other PRs
I ran
black awx awxkitISSUE TYPE
COMPONENT NAME