Do not create setting with invalid value in data migration #13576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFSNM
approved these changes
Feb 15, 2023
jjwatt
pushed a commit
to jjwatt/awx
that referenced
this pull request
Mar 3, 2023
…3576) * Do not create setting with invalid value in data migration * Add test for conf app data migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Do a new install and check
/api/v2/settings/ldap/"AUTH_LDAP_GROUP_TYPE_PARAMS": {},This is an invalid value, and will fail the validation not for itself, but for
AUTH_LDAP_GROUP_TYPE, which uses these params to initialize a library object. The class of that object takes a positional argument, so{}throws an exception, not meeting the method signature.Check the settings in the database.
The data migration created an entry for this key.
ISSUE TYPE
COMPONENT NAME