Use ansible-runner change to get periodic keep-alive messages in K8S #13608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
force-pushed
the
keepalive
branch
from
bb817e7
to
fee8ca5
Compare
|
I tested building the UI, and then I was able to edit and save the value of the setting. Without UI changes I was able to see the setting, but not able to edit it. I know some changes here are just test file changes. |
|
UI changes lgtm |
shanemcd
reviewed
Feb 22, 2023
AlanCoding
force-pushed
the
keepalive
branch
from
99a00a4
to
dc72d99
Compare
AlanCoding
commented
Feb 27, 2023
| @@ -85,6 +85,8 @@ def event_handler(self, event_data): | |||
| # which generate job events from two 'streams': | |||
| # ansible-inventory and the awx.main.commands.inventory_import | |||
| # logger | |||
| if event_data.get('event') == 'keepalive': | |||
| return | |||
There was a problem hiding this comment.
From discussion with @TheRealHaoLiu, we are unlikely to need this, but I would prefer to keep it in anyway. Maybe leave a comment that it should be dead code.
AlanCoding
commented
Feb 27, 2023
| @@ -282,6 +282,16 @@ | |||
| placeholder={'HTTP_PROXY': 'myproxy.local:8080'}, | |||
| ) | |||
|
|
|||
| register( | |||
| 'AWX_RUNNER_KEEPALIVE_SECONDS', | |||
There was a problem hiding this comment.
should we rename this to something about K8S_?
Make setting API configurable and process keepalive events when seen in the event callback Use env var in pod spec and make it specific to K8S
Co-authored-by: Shane McDonald <me@shanemcd.com>
AlanCoding
force-pushed
the
keepalive
branch
from
dc72d99
to
90f54b9
Compare
CFSNM
approved these changes
Feb 28, 2023
This was referenced Mar 6, 2023
Send "keep alive" (empty) messages to avoid idle timeouts when streaming
ansible/ansible-runner#1187
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a candidate patch for consuming ansible/ansible-runner#1191, which adds keepalive messages.
FYI for @nitzmahone, I hope we are narrowing in on this implementation. This will require keeping and supporting the environment variable. There are no plans to use the CLI flag. I also maintain a weak preference to have the event callback pass on the keep-alive events.
ISSUE TYPE
COMPONENT NAME