Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for a pseudolocalization and lang query params #13661

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

mabashian
Copy link
Member

SUMMARY

This work follows #9537. The changes here allow a developer to add ?pseudolocalization=true to the query parameters in the URL to check to see if a rendered string has been marked for translation. All strings marked for translation will be wrapped in carats like so: >>string<<. Unmarked strings will render without the carats. Note that a hard reload is required for the changes to take effect. Also note that this only works for strings defined in the UI. Strings that get rendered in the interface that come from API call responses will not be wrapped in carats.

pseudolocalization

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • UI

@mabashian mabashian changed the title Adds support for a pseudolocalization query param to check to see whether a string has been marked for translation Adds support for a pseudolocalization and lang query params Mar 8, 2023
@mabashian
Copy link
Member Author

Also added support for ?lang= to allow a user to force the ui to render in a particular language regardless of the specified browser language.

lang

@jay-steurer jay-steurer self-requested a review March 13, 2023 18:04
…ther a string has been marked for translation

Adds support for a pseudolocalization query param to check to see whether a string has been marked for translation
@cypress
Copy link

cypress bot commented Mar 14, 2023

2 failed tests on run #14663 ↗︎

2 702 611 0 Flakiness 0

Details:

Remove unused import
Project: AWX - Functional Commit: b2ac106584
Status: Failed Duration: 06:14 💡
Started: Mar 14, 2023 8:28 PM Ended: Mar 14, 2023 9:34 PM
Failed  cypress/e2e/integration/job-templates/job-template-prompt-on-launch.cy.js • 2 failed tests

View Output Video

Test Artifacts
Prompt on Launch - JT-Specific Credential Prompts- Adding to JT on Prompt > can add one of each credential type to a job Output Screenshots Video
Prompt on Launch - JT-Specific Credential Prompts > can add two different types of credentials to a job through prompt on launch wizard Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jay-steurer
Copy link
Contributor

Verified by QE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants