-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for a pseudolocalization and lang query params #13661
Merged
jay-steurer
merged 3 commits into
ansible:devel
from
mabashian:pseudolocalization-param
Mar 15, 2023
Merged
Adds support for a pseudolocalization and lang query params #13661
jay-steurer
merged 3 commits into
ansible:devel
from
mabashian:pseudolocalization-param
Mar 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabashian
changed the title
Adds support for a pseudolocalization query param to check to see whether a string has been marked for translation
Adds support for a pseudolocalization and lang query params
Mar 8, 2023
keithjgrant
approved these changes
Mar 8, 2023
marshmalien
approved these changes
Mar 8, 2023
…ther a string has been marked for translation Adds support for a pseudolocalization query param to check to see whether a string has been marked for translation
mabashian
force-pushed
the
pseudolocalization-param
branch
from
March 14, 2023 15:38
9b7d8a4
to
b2ac106
Compare
2 failed tests on run #14663 ↗︎
Details:
cypress/e2e/integration/job-templates/job-template-prompt-on-launch.cy.js • 2 failed testsThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Verified by QE |
This was referenced Mar 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This work follows #9537. The changes here allow a developer to add ?pseudolocalization=true to the query parameters in the URL to check to see if a rendered string has been marked for translation. All strings marked for translation will be wrapped in carats like so:
>>string<<
. Unmarked strings will render without the carats. Note that a hard reload is required for the changes to take effect. Also note that this only works for strings defined in the UI. Strings that get rendered in the interface that come from API call responses will not be wrapped in carats.ISSUE TYPE
COMPONENT NAME