Add migration for new cyberark plugin names

[obaranov]

SUMMARY

Fixed issue with the migration of the new names: #13669

ISSUE TYPE

• Bug, Docs Fix or other nominal change

COMPONENT NAME

• API

AWX VERSION

awx: 21.13.1.dev64+g268f884e92

ADDITIONAL INFORMATION

[AlanCoding]

I think you're close here, with the addition of an .order_by('created') maybe. Needs testing.

I like that a lot better than having to reference specific names. In fact, this might be something that can be written generally, and applied to all managed types (instead of 2 operations).

Should add logging, in case a change is made, it is important to alert the user to it for auditing.

[AlanCoding]

This is a good near-term fix, but longer-term I would like to followup and adjust the logic inside of CredentialType.setup_tower_managed_defaults so that we won't need to do this again. Ideally, we could do this the next time that a credential type name is changed.

[obaranov]

I think you're close here, with the addition of an .order_by('created') maybe. Needs testing.

I like that a lot better than having to reference specific names. In fact, this might be something that can be written generally, and applied to all managed types (instead of 2 operations).

Should add logging, in case a change is made, it is important to alert the user to it for auditing.

I added logging and reduced everything to one operation. I also checked that existing credentials were properly migrated after upgrade:

Also added upgrade API tests here: https://github.com/ansible/tower-qa/pull/8021