Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "password": "$encrypted$" to user serializer #13704

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

john-westcott-iv
Copy link
Member

SUMMARY

The awx.awx.user module was not respecting the update_secrets parameter even though it looked like it. This was due to the user object not having the "password" field in the serializer.

This change adds the password field if the user is an internal user.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION

ADDITIONAL INFORMATION

Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to mark this for a release note!

@Klaas-
Copy link
Contributor

Klaas- commented Mar 16, 2023

I have a side question -- should there also be a possibility of "no password" -- for example a social user is not created with a password (in db the password is not a valid hash but populated with some random[?] string) nevermind, I wanted to post it in the issue not on the PR :)

@jay-steurer jay-steurer merged commit 8c187c7 into ansible:devel Apr 25, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants