Match CodeMirror mode to value type on initialization #13708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishsanghishetty
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #13675
Update VariablesField to check the
field.valuebefore setting themodeto YAML or JSON.The bug was caused by a brief, initial mismatch between the mode and field.value. When the variables field is in YAML mode, we set
lastYamlValueto the current field value, assuming the value is in YAML. If the user does not edit the variables field in JSON mode, then switches to YAML mode, we set the YAML value back tolastYamlValueto prevent the field from unnecessarily expanding YAML expressions. Whenever the initial value was a json string AND mode === yaml, this would break the conversion sincelastYamlValuewas set to a json string instead of a yaml value.RECORDINGS
edit_form_variables_toggle.mov
Screen.Recording.2023-03-16.at.11.00.21.AM.mov
ISSUE TYPE
COMPONENT NAME