Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-clean target, accounting for slashes #13786

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

AlanCoding
Copy link
Member

SUMMARY

As documented in moby/moby#36196, the docker reference= notion does not support /. This is a problem, as it makes the prior filter completely non-functional:

docker images --filter=reference='*awx_devel*' -aq

This returns no images because * does not match ghcr.io/ansible, as per the file glob philosophy - and requests for an expansion pattern ** that include slashes (as per file globs) have been denied.

Multiple --filter arguments will OR the criteria together, so we are safe to allow fewer slashes by being slightly redundant, as I am doing here. This is essentially a poor person's version of **.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
ADDITIONAL INFORMATION

Because web/task split just merged, it goes without saying that many people will need an image refresh.

@AlanCoding AlanCoding changed the title Fix docker-clean file, accounting for slashes Fix docker-clean target, accounting for slashes Mar 30, 2023
@AlanCoding AlanCoding requested a review from jjwatt March 30, 2023 17:54
@AlanCoding AlanCoding merged commit 2db29e5 into ansible:devel Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants