Adding basic validation for local passwords #13789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-westcott-iv
force-pushed
the
local_user_passwords
branch
from
06a203f
to
b211f3c
Compare
fosterseth
reviewed
Apr 6, 2023
| register( | ||
| 'LOCAL_PASSWORD_MIN_LENGTH', | ||
| field_class=fields.IntegerField, | ||
| min_value=0, |
There was a problem hiding this comment.
does the django validation have a minimum? would it make sense to restrict the min to whatever that value is?
There was a problem hiding this comment.
Technically it can't be blank but you can set a password to a (so min 1) but I wanted 0 to mean "check disabled".
fosterseth
reviewed
Apr 6, 2023
| password_max_length = User._meta.get_field('password').max_length | ||
| if len(value) > password_max_length: | ||
| raise serializers.ValidationError(_('Password max length is {}'.format(password_max_length))) | ||
| if getattr(settings, 'LOCAL_PASSWORD_MIN_LENGTH', 0) and len(value) < getattr(settings, 'LOCAL_PASSWORD_MIN_LENGTH'): |
There was a problem hiding this comment.
if these settings are in the db with default values already, would
if len(value) < getattr(settings, 'LOCAL_PASSWORD_MIN_LENGTH'):suffice?
There was a problem hiding this comment.
Probably, I was thinking that since 0 means "no check" we would start with that to prevent the second checks from even being looked at. But I suppose its only a string compare/small loops so the amount of time saved by the short circuiting the if clause is probably negligible.
fosterseth
approved these changes
Apr 7, 2023
john-westcott-iv
force-pushed
the
local_user_passwords
branch
2 times, most recently
from
79153fb
to
0dd7d4d
Compare
john-westcott-iv
force-pushed
the
local_user_passwords
branch
from
0dd7d4d
to
1bc70d8
Compare
jay-steurer
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds 4 definable password rules for local user passwords:
Also synced and prettied the UI files:
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION