Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing check for all in awx.awx.export #13854

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Changing check for all in awx.awx.export #13854

merged 1 commit into from
Apr 18, 2023

Conversation

john-westcott-iv
Copy link
Member

SUMMARY

Fixes #13853

The fields used to be strings but at some point converted to arrays. The check for == 'all' never matched == ['all'] so exporting everything of a type would never work.

To test, run a playbook like:

---
- name: Export the inventory
  hosts: localhost
  connection: local
  gather_facts: False
  tasks:
    - awx.awx.export:
        inventory: ['something', 'all']
        controller_host: https://localhost:8043
        controller_username: admin
        controller_password: admin
        validate_certs: False
      register: inventory

    - debug:
        var: inventory

The exported inventories would be [] (because it was looking for an inventory named all). After the fix the exported inventories should match your instance.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Collection
AWX VERSION
ADDITIONAL INFORMATION

@github-actions github-actions bot added the component:awx_collection issues related to the collection for controlling AWX label Apr 13, 2023
TheRealHaoLiu
TheRealHaoLiu approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@TheRealHaoLiu TheRealHaoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and verified that 'all' now works

sean-m-sullivan
sean-m-sullivan approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, this works

@john-westcott-iv john-westcott-iv self-assigned this Apr 14, 2023
@jay-steurer jay-steurer self-requested a review April 17, 2023 11:12
@jay-steurer jay-steurer merged commit 32f7dfe into ansible:devel Apr 18, 2023
15 checks passed
@fosterseth fosterseth mentioned this pull request Jun 14, 2023
Merged
AlanCoding pushed a commit to AlanCoding/awx that referenced this pull request Aug 10, 2023
@TheRealHaoLiu @john-westcott-iv
Changing check for all in awx.awx.export (ansible#13854) (ansible#6455)
a7c38ac 
Co-authored-by: John Westcott IV <32551173+john-westcott-iv@users.noreply.github.com>
kdelee pushed a commit to kdelee/awx that referenced this pull request May 8, 2024
@TheRealHaoLiu @john-westcott-iv
Changing check for all in awx.awx.export (ansible#13854) (ansible#6456)
399bfff 
Co-authored-by: John Westcott IV <32551173+john-westcott-iv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-m-sullivan sean-m-sullivan sean-m-sullivan approved these changes

@TheRealHaoLiu TheRealHaoLiu TheRealHaoLiu approved these changes

@jay-steurer jay-steurer jay-steurer approved these changes

Assignees

@john-westcott-iv john-westcott-iv

Labels
component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: awx.awx.export all does not work.
4 participants
@john-westcott-iv @sean-m-sullivan @TheRealHaoLiu @jay-steurer