Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : awx.awx.group preserve hosts fails when there are no hosts #13913

Merged
merged 8 commits into from
Jun 7, 2023

Conversation

darshanip
Copy link
Contributor

@darshanip darshanip commented Apr 26, 2023

SUMMARY

Fixes #11954

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Collection

@github-actions github-actions bot added the component:awx_collection issues related to the collection for controlling AWX label Apr 26, 2023
@fosterseth
Copy link
Member

@sean-m-sullivan do you mind taking a look at this PR?

@darshanip do you mind adding a test case around this? A new test case in this file

- name: Create a Group with hosts and sub group

darshanip and others added 3 commits April 27, 2023 20:48
If group does not exist, then it fails as well, comes back None for `group`
Copy link
Contributor

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and LGTM

@darshanip
Copy link
Contributor Author

@fosterseth can someone verify test cases.

@rebeccahhh
Copy link
Member

@fosterseth is this good to merge?

@fosterseth fosterseth merged commit 3c22fc9 into ansible:devel Jun 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awx.awx.group option preserve hosts fails when there are no hosts.
4 participants