Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send real client remote address in TACACS+ authentication packet #14077

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

john-westcott-iv
Copy link
Member

SUMMARY

Replaces #13118

Addresses #1797, to add the client IP when authenticating in TACACS+

The client IP is extracted from one of the following header in the request in this order: x-forwarded-for, remote-addr.
If none of those are found it is behaving like previously (no value is passed and the default client flag is used)

ISSUE

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API
AWX VERSION

ADDITIONAL INFORMATION

Copy link
Member

@TheRealHaoLiu TheRealHaoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@john-westcott-iv john-westcott-iv merged commit 844666d into ansible:devel Jun 2, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants