Using execution_environment option in ad_hoc_command module #14105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:awx_collection
|
thanks for this contribution, we'll be taking a look at it soon |
| @@ -158,6 +159,8 @@ def main(): | |||
| # Attempt to look up the related items the user specified (these will fail the module if not found) | |||
| post_data['inventory'] = module.resolve_name_to_id('inventories', inventory) | |||
| post_data['credential'] = module.resolve_name_to_id('credentials', credential) | |||
| if execution_environment: | |||
| post_data['execution_environment'] = module.resolve_name_to_id('execution_environments', execution_environment) | |||
There was a problem hiding this comment.
Can we add an test in awx_collection/tests/integration/targets/ad_hoc_command/tasks/main.yml for this?
There was a problem hiding this comment.
@john-westcott-iv Thank you for reviewing. I added integration test.
jessicamack
approved these changes
Jun 22, 2023
|
@akira6592 Thank you again for the contribution. I've confirmed the new integration test passes. Approving and merging. |
|
@jessicamack Thank you for merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #14104
Using execution_environment option in
ad_hoc_commandmodule.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION