Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed pin of rsyslog version #14117

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

john-westcott-iv
Copy link
Member

@john-westcott-iv john-westcott-iv commented Jun 13, 2023

SUMMARY

We had previously pinned rsyslog to a specific version in #13395. This is because rsyslog added a new feature that broke it running inside a container:

=================================== FAILURES ===================================
________________ test_logging_aggregator_connection_test_valid _________________
[gw0] linux -- Python 3.9.16 /var/lib/awx/venv/awx/bin/python3.9
Traceback (most recent call last):
  File "/awx_devel/awx/main/tests/functional/api/test_settings.py", line 320, in test_logging_aggregator_connection_test_valid
    post(url, {}, user=admin, expect=202)
  File "/awx_devel/awx/main/tests/functional/conftest.py", line 633, in rf
    assert response.status_code == expect, 'Response data: {}'.format(getattr(response, 'data', None))
AssertionError: Response data: {'error': "b'rsyslog internal message (3,-2455): could not transfer  the  specified  internal posix  capabilities settings to the kernel, capng_apply=-5\\n [v8.2102.0-115.el9 try https://www.rsyslog.com/e/2455 ]\\n'"}
assert 400 == 202
 +  where 400 = <Response status_code=400, "text/html; charset=utf-8">.status_code

There is a PR against rsyslog to make the option a runtime option rather than a compiled option rsyslog/rsyslog#5144 but until that is merged we need to continue to run on an older version. The version we used to run on was removed from the repositories so all builds were failing. This PR pins the version of rsyslog that we use a slightly newer version that still works. This is considered to be a temporary solution to get things working again until we can find a more permanent solution.

Fixes #14115

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION

ADDITIONAL INFORMATION

@john-westcott-iv john-westcott-iv changed the title Unpinning rsyslog version Changed pin of rsyslog version Jun 13, 2023
@john-westcott-iv john-westcott-iv merged commit d1d08fe into ansible:devel Jun 13, 2023
16 checks passed
@shanemcd shanemcd mentioned this pull request Jun 14, 2023
AlanCoding added a commit to AlanCoding/awx that referenced this pull request Jul 13, 2023
* Changed pin of rsyslog version (ansible#14117)

* Fix ARM builds (ansible#14125)

---------

Co-authored-by: John Westcott IV <32551173+john-westcott-iv@users.noreply.github.com>
Co-authored-by: Shane McDonald <me@shanemcd.com>
AlexSCorey pushed a commit to AlexSCorey/awx that referenced this pull request Jul 26, 2023
* Changed pin of rsyslog version (ansible#14117)

* Adding import of centos repo key for dnf

* Fix ARM builds (ansible#14125)

---------

Co-authored-by: John Westcott IV <32551173+john-westcott-iv@users.noreply.github.com>
Co-authored-by: John Westcott IV <john.westcott.iv@redhat.com>
Co-authored-by: Shane McDonald <me@shanemcd.com>
@pfeifferj
Copy link

FYI: rsyslog/rsyslog#5144 was merged upstream in case you want to test with a newer version of rsyslog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose-build does not build. Wrong rsyslog version.
3 participants