Respect old downtime setting name if user has already set it #14361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Do we have a way to deprecate old settings and show a Otherwise, I don't see how we get people to stop using the old one. |
|
There are a great deal of settings that are only documented by their existence in the defaults file. That file does have a fairly robust comment with each setting. The setting has already been renamed in that location. |
dmzoneill
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Followup from https://github.com/ansible/awx/pull/14347/files
The concern is that if anyone was already using this, that it will stop working with that change. We need a window for upgrades without any disruption. Eventually we can remove this.
ISSUE TYPE
COMPONENT NAME