Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alt text for image directives in job_templates.rst #14548

Merged
merged 2 commits into from Oct 19, 2023
Merged

Add alt text for image directives in job_templates.rst #14548

merged 2 commits into from Oct 19, 2023

Conversation

kishan3
Copy link
Contributor

@kishan3 kishan3 commented Oct 6, 2023

Fixes #14509

SUMMARY

Added alt test for image directives in job_templates.rst

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Docs

@kishan3
Copy link
Contributor Author

kishan3 commented Oct 10, 2023

Hi @tvo318 can you please check my PR if anything required?

@oraNod oraNod added the Hacktoberfest Issues tagged for Hacktoberfest label Oct 10, 2023
@oraNod
Copy link
Collaborator

oraNod commented Oct 10, 2023

Hi @kishan3 Thanks for the contribution!

Can you please amend your final commit to do the DCO signoff per the Contributor's Guide guidelines?

  1. git commit --signoff
  2. Push to your branch

@tvo318 tvo318 self-requested a review October 12, 2023 21:24
@kishan3
Copy link
Contributor Author

kishan3 commented Oct 13, 2023

Hi @tvo318 @oraNod I updated PR with signoff commit.

tvo318
tvo318 requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@tvo318 tvo318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a couple minor inputs. Thanks for contributing!

docs/docsite/rst/userguide/job_templates.rst Outdated Show resolved Hide resolved
docs/docsite/rst/userguide/job_templates.rst Outdated Show resolved Hide resolved
@kishan3 kishan3 requested a review from tvo318 October 17, 2023 08:02
tvo318
tvo318 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@tvo318 tvo318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thank you for your contribution, @kishan3 🎉

@tvo318 tvo318 enabled auto-merge (squash) October 19, 2023 20:00
@tvo318 tvo318 merged commit 0bd0575 into ansible:devel Oct 19, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvo318 tvo318 tvo318 approved these changes

Assignees
No one assigned
Labels
community component:docs Hacktoberfest Issues tagged for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Add alt-text codeblock to Images for Userguide: job_templates.rst
3 participants
@kishan3 @oraNod @tvo318