Fixed/updated URL for “Passing Variables on the Command Line" link. #14763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedoubl3j
approved these changes
Jan 12, 2024
oraNod
approved these changes
Jan 15, 2024
|
@tvo318 Hey this looks great and it's super cool to see that an issue that originated downstream gets ported to community docs! 🎉 Just one thing to note, it might be preferable to avoid linking Jira tickets in GH issues. Community users can't access those details. IMO it's also a best practice to avoid potentially leaking sensitive details like customer info or vulnerabilities. On other projects where a downstream issue goes to community I've put in a generic description like "Porting changes from Controller documentation". It's still good to make it obvious the change originates downstream. Over time all those little changes add up and it helps to show how community wins! |
samccann
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Porting changes from Controller documentation to fix broken link in the Job Templates chapter of the User Guide.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
latest